add find tool formatters#1020
Open
LasmarKhalifa wants to merge 1 commit into
Open
Conversation
This was referenced Jul 2, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-find
branch
from
2eeb38f to
eba0fd6
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-grep
branch
from
86c73f5 to
3b64e5c
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-find
branch
from
eba0fd6 to
96d8a9b
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-grep
branch
from
3b64e5c to
10a0676
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-find
branch
from
96d8a9b to
554abfb
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-grep
branch
2 times, most recently
from
3799ee2 to
919a175
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-find
branch
from
554abfb to
8a4b6f3
Compare
LasmarKhalifa
force-pushed
the
07-02/pi-tool-formatter-find
branch
from
8a4b6f3 to
621fd97
Compare
LasmarKhalifa
requested review from
dersam,
juniper-shopify,
mathiusj and
nfgrep
as code owners
mathiusj
reviewed
Jul 3, 2026
mathiusj
left a comment
mathiusj
left a comment
Contributor
There was a problem hiding this comment.
find formatter looks good.
| # FIND OK 0 paths | ||
| # | ||
| #: () -> String | ||
| def format_find |
Contributor
There was a problem hiding this comment.
Consistency note (also raised on #1017): this drops blank lines via .map(&:strip).reject(&:empty?), whereas format_read counts raw .lines.length. Fine if intentional (paths vs. file lines), but the two counting rules across sibling formatters should be a conscious, ideally documented, choice.
mathiusj
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1028