Group class and module indexing tests into dedicated test module#664
Open
alexcrocha wants to merge 1 commit into03-26-move_ruby_indexer_tests_to_separate_filefrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
alexcrocha
added
the
chore
vinistock
reviewed
Mar 16, 2026
alexcrocha
force-pushed
the
03-13-extract_class_and_module_tests_from_monolithic_mod_tests
branch
2 times, most recently
from
393ad5f to
6356a83
Compare
vinistock
approved these changes
Mar 18, 2026
Morriar
reviewed
Mar 24, 2026
Contributor
Morriar
left a comment
Morriar
left a comment
There was a problem hiding this comment.
Considering the size of this file, should we start extracting these tests in external test files?
Improves discoverability for both editor navigation (document symbols) and code search by giving class/module definition tests a named boundary
alexcrocha
force-pushed
the
03-13-extract_class_and_module_tests_from_monolithic_mod_tests
branch
from
6356a83 to
deb574e
Compare
alexcrocha
changed the base branch from
graphite-base/664
to
03-26-move_ruby_indexer_tests_to_separate_file
Contributor
Author
Documenting the outcome of this question here. After a brief chat async, the team decided it was indeed time to split the tests into their own file. #705 is the new base of this stack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the second in a stack that addresses #649.
By grouping class and module indexing tests into a dedicated test module, we improve discoverability for both editor navigation and code search by giving class/module definition tests a named boundary.
Follows the existing
name_dependent_testspattern.