Specialize reference IDs#699
Open
vinistock wants to merge 1 commit into03-26-remove_reference_diagnostics_from_documentsfrom
Open
Specialize reference IDs#699vinistock wants to merge 1 commit into03-26-remove_reference_diagnostics_from_documentsfrom
vinistock wants to merge 1 commit into03-26-remove_reference_diagnostics_from_documentsfrom
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I started trying to improve our Ruby API for references, I realized that a lot about is a bit weird at the moment. I will try to improve the type safety and quality as part of better exposing references in the API.
This PR ensures that we have specialized reference IDs for each declaration entity. It does not make sense to have a
Constantdeclaration with aMethodReferenceassociated to it, so this change prevents that from happening.It does mean that we need to narrow types in a few places, but I think that's an acceptable trade-off for much better type safety.
Note: we don't yet index global, class or instance variable references. I already added the IDs because it's easier to make this refactor with proper types. Also, we do need to index those references too, so this is a change towards that as well.