Skip to content

Update the TOML schema#207

Closed
gonzaloriestra wants to merge 1 commit intojavascript-clifrom
add-client-id-to-toml-javascript-cli
Closed

Update the TOML schema#207
gonzaloriestra wants to merge 1 commit intojavascript-clifrom
add-client-id-to-toml-javascript-cli

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

@gonzaloriestra gonzaloriestra commented Mar 19, 2026

WHY are these changes introduced?

In Shopify/cli#6612 we removed support for the legacy app schema.

WHAT is this pull request doing?

Update the template to include a default client_id and move the scopes under [access_scopes] to match the new schema.

That way, old CLI versions and the next one without the legacy schema should work.

Test this PR

shopify app init --template=https://github.com/Shopify/shopify-app-template-react-router#add-client-id-to-toml-javascript-cli

Checklist

  • I have made changes to the README.md file and other related documentation, if applicable
  • I have added an entry to CHANGELOG.md
  • I'm aware I need to create a new release when this PR is merged

@gonzaloriestra gonzaloriestra requested a review from a team as a code owner March 19, 2026 14:07
Copy link
Copy Markdown

@alfonso-noriega alfonso-noriega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups! good catch ;)

@gonzaloriestra gonzaloriestra deleted the add-client-id-to-toml-javascript-cli branch March 19, 2026 15:01
@gonzaloriestra gonzaloriestra restored the add-client-id-to-toml-javascript-cli branch March 19, 2026 15:05
@gonzaloriestra gonzaloriestra deleted the add-client-id-to-toml-javascript-cli branch March 19, 2026 15:05
@gonzaloriestra
Copy link
Copy Markdown
Contributor Author

Closing in favor of #208

It contains the same changes, but the branch starts with javascript, and that way the CI skips the TS checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants