Skip to content

Validate host param in generated HomeController template #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amcaplan merged 1 commit into from
Mar 4, 2026
+5 −1
Merged

Validate host param in generated HomeController template #2059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Unreleased
----------
- [Patch] Validate host param in generated HomeController template to prevent open redirect
- [Patch] Fix sorbet errors in generated webhook handlers

23.0.1 (December 22, 2025)
Expand Down
4 changes: 3 additions & 1 deletion lib/generators/shopify_app/home_controller/templates/unauthenticated_home_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ class HomeController < ApplicationController

def index
if ShopifyAPI::Context.embedded? && (!params[:embedded].present? || params[:embedded] != "1")
redirect_to(ShopifyAPI::Auth.embedded_app_url(params[:host]) + request.path, allow_other_host: true)
redirect_url = ShopifyAPI::Auth.embedded_app_url(params[:host]) + request.path
redirect_url = ShopifyApp.configuration.root_url if deduced_phishing_attack?(redirect_url)
redirect_to(redirect_url, allow_other_host: true)
else
@shop_origin = current_shopify_domain
@host = params[:host]
Expand Down
1 change: 1 addition & 0 deletions test/generators/home_controller_generator_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class HomeControllerGeneratorTest < Rails::Generators::TestCase
assert_match "include ShopifyApp::ShopAccessScopesVerification", file
assert_match "include ShopifyApp::EmbeddedApp", file
assert_match "include ShopifyApp::EnsureInstalled", file
assert_match "deduced_phishing_attack?", file
end
assert_file "app/views/home/index.html.erb"
end
Expand Down