Add rubocop-minitest#920
Open
amomchilov wants to merge 6 commits into
Open
Conversation
Morriar
reviewed
May 13, 2026
|
|
||
| sha = T.must(context.git_last_commit(short_sha: false)).sha | ||
| assert(sha.size == 40) | ||
| assert_equal(sha.size, 40) |
Contributor
There was a problem hiding this comment.
The auto-correct put the arguments in the wrong order. Convention is assert_equal(expected, actual), and the line right below follows it correctly.
Suggested change
| assert_equal(sha.size, 40) | |
| assert_equal(40, sha.size) |
Contributor
Author
There was a problem hiding this comment.
Ah Minitest/LiteralAsActualArgument is not enabled by default yet (it's pending). I enabled it and auto-corrected this.
amomchilov
force-pushed
the
Alex/rubocop-minitest
branch
from
a0ab66c to
ffb56e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And turn on
Minitest/AssertPredicate, matching Ruby LSP