Skip to content

Fix auth headers #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChrisBr wants to merge 1 commit into
base: tecnix-gcs
Choose a base branch
from
Open

Fix auth headers #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/libfetchers/tarball.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ static DownloadTarballResult downloadTarball_(

auto source = sinkToSource([&](Sink & sink) {
FileTransferRequest req(url);
req.headers = headers;
req.expectedETag = cached ? getStrAttr(cached->value, "etag") : "";
getFileTransfer()->download(std::move(req), sink, [_res](FileTransferResult r) { *_res->lock() = r; });
});
Expand Down Expand Up @@ -484,7 +485,20 @@ struct TarballInputScheme : CurlInputScheme
{
auto input(_input);

auto result = downloadTarball_(settings, getStrAttr(input.attrs, "url"), {}, "«" + input.to_string() + "»");
auto urlS = getStrAttr(input.attrs, "url");

// Build auth headers from access-tokens for the URL's host.
Headers headers;
auto parsedUrl = parseURL(urlS);
if (parsedUrl.authority) {
auto & host = parsedUrl.authority->host;
auto tokens = settings.accessTokens.get();
if (auto token = get(tokens, host)) {
headers.push_back({"Authorization", fmt("token %s", *token)});
Copy link
Copy Markdown

@lilyinstarlight lilyinstarlight Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub supports Authorization: Bearer[1] so for more generalized support (since most forges require that), we should use Bearer

Suggested change
headers.push_back({"Authorization", fmt("token %s", *token)});
headers.push_back({"Authorization", fmt("Bearer %s", *token)});

}
}

auto result = downloadTarball_(settings, urlS, headers, "«" + input.to_string() + "»");

if (result.immutableUrl) {
auto immutableInput = Input::fromURL(settings, *result.immutableUrl);
Expand Down
Loading