Enable pipe-operators experimental feature by default#17
Open
surma wants to merge 1 commit intotecnix-gcsfrom
Open
Enable pipe-operators experimental feature by default#17surma wants to merge 1 commit intotecnix-gcsfrom
surma wants to merge 1 commit intotecnix-gcsfrom
Conversation
Uses extra-experimental-features to append pipe-operators after config loading, so it's always enabled regardless of any user-configured experimental-features setting. The pipe operator (`|>` and `<|`) is used heavily in Tecnix/Tectonix Nix expressions at Shopify. Co-authored-by: Surma Surma <surma@shopify.com>
shopify-river
bot
force-pushed
the
enable-pipe-operators-by-default
branch
from
f69130e to
0bdab8e
Compare
lilyinstarlight
left a comment
lilyinstarlight
left a comment
There was a problem hiding this comment.
Looks like you also need to remove tests/functional/lang/eval-fail-pipe-operators.nix and tests/functional/lang/eval-fail-pipe-operators.err.exp as well (otherwise functional tests fail, since apparently experimental feature eval failures are included in language tests?)
Otherwise this should be good on a technical level (even if I am still mildly worried about carrying divergence like this when we can keep these sorts of things in the global config (and I'm more worried about things that can't be global, e.g. keeping the machinery on our side to inject --lazy-trees and --extra-experimental-features parallel-eval etc only for tecnix/detnix, until we have tecnix nix-daemon anyway))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pipe operator (
|>and<|) is used heavily in Tecnix/Tectonix Nix expressions at Shopify. This change makes it enabled by default, similar to how flakes and nix-command were enabled by default before being stabilized.This sets PipeOperators in the default value of the experimental-features setting, so users no longer need to explicitly opt in.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.