Fix extracting lfs.url from git config#19
Merged
gmpify merged 3 commits intotecnix-gcsfrom Mar 24, 2026
Merged
Conversation
Fixes: * Only add `/info/lfs` (and possibly `.git`) to remotes * Properly have `href` field from SSH server discovery be optional * Do not remove/re-add `/info/lfs` to `lfs.url` config and use it directly as LFS API endpoint
lilyinstarlight
approved these changes
Mar 24, 2026
lilyinstarlight
left a comment
lilyinstarlight
left a comment
There was a problem hiding this comment.
Looks good and everything worked correctly when tested after latest change!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #13
This PR:
git_repository_configreturns 0 when it can successfully read a git config file (as seen in docs). There was a bug here, causing nix to never get the existing config./info/lfsfrom the URL, given thatlfs.urlwould usually have this suffix. This change makes this return path in line with the others in the rest of the function, where it extracts the URL from theoriginremote.This change fixes tecnix to work with wcb.