Add builtins.unsafeTectonixInternalZonePath#21
Open
joshheinrichs-shopify wants to merge 1 commit intotecnix-gcsfrom
Open
Add builtins.unsafeTectonixInternalZonePath#21joshheinrichs-shopify wants to merge 1 commit intotecnix-gcsfrom
joshheinrichs-shopify wants to merge 1 commit intotecnix-gcsfrom
Conversation
joshheinrichs-shopify
force-pushed
the
path-not-string
branch
from
1d40dfb to
c73d0a2
Compare
joshheinrichs-shopify
force-pushed
the
path-not-string
branch
from
c73d0a2 to
acb6d8d
Compare
joshheinrichs-shopify
changed the title
Basically the same as builtins.unsafeTectonixInternalZoneSrc but returns a path. Some existing callers are using string interpolation so we can't swap builtins.unsafeTectonixInternalZoneSrc over to a path without significantly regressing performance.
joshheinrichs-shopify
force-pushed
the
path-not-string
branch
from
acb6d8d to
e4f3b71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically the same as builtins.unsafeTectonixInternalZoneSrc but returns
a path. Some existing callers are using string interpolation so we can't
swap builtins.unsafeTectonixInternalZoneSrc over to a path without
significantly regressing performance.