Skip to content

fix sending genesis blocks to peers in syncLoop #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n8mgr merged 2 commits into from
Feb 24, 2026
Merged

fix sending genesis blocks to peers in syncLoop #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90f140e
fix sending genesis blocks to peers in syncLoop
ChrisSchinnerl Feb 24, 2026
cc206a4
changeset
ChrisSchinnerl Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...case_where_a_node_incorrectly_sends_the_genesis_state_to_peers_while_syncing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
default: patch
---

# Fix edge case where a node incorrectly sends the genesis state to peers while syncing.
5 changes: 5 additions & 0 deletions syncer/syncer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,6 +680,11 @@ func (s *Syncer) syncLoop(ctx context.Context) error {
go func(p *Peer) {
cs, headers, remaining, err := func() (consensus.State, []types.BlockHeader, uint64, error) {
for _, id := range hist {
if id == (types.BlockID{}) {
// skip empty history entries which can occur when
// we don't have a full history of blocks.
continue
}
cs, ok := s.cm.State(id)
if !ok {
return consensus.State{}, nil, 0, errors.New("missing state for history")
Expand Down