Skip to content

Fix SideStore/SideStore#227 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dadoum wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix SideStore/SideStore#227 #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43b9013
Fix SideStore/SideStore#227
Dadoum Sep 15, 2025
7428750
Fix the fix
Dadoum Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions ldid.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2700,25 +2700,36 @@ Bundle Sign(const std::string &root, Folder &folder, const std::string &key, std
};

uint8_t bytes[8];
uint filetype;
} header;

auto size(most(data, &header.bytes, sizeof(header.bytes)));

if (name != "_WatchKitStub/WK" && size == sizeof(header.bytes))
if (name != "_WatchKitStub/WK" && size == sizeof(header.bytes)) {
switch (Swap(header.magic)) {
case FAT_MAGIC:
// Java class file format
if (Swap(header.count) >= 40)
break;
case FAT_CIGAM:
return;
break;
case MH_MAGIC: case MH_MAGIC_64:
// Skip object files
if (header.filetype == MH_OBJECT)
return;
break;
case MH_CIGAM: case MH_CIGAM_64:
folder.Save(name, true, flag, fun([&](std::streambuf &save) {
Slots slots;
Sign(header.bytes, size, data, hash, save, identifier, "", "", key, slots, length, percent);
}));
return;
// Skip object files (should we swap here?)
if (Swap(header.filetype) == MH_OBJECT)
return;
break;
case FAT_CIGAM:
break;
}
folder.Save(name, true, flag, fun([&](std::streambuf &save) {
Slots slots;
Sign(header.bytes, size, data, hash, save, identifier, "", "", key, slots, length, percent);
}));
}

folder.Save(name, false, flag, fun([&](std::streambuf &save) {
HashProxy proxy(hash, save);
Expand Down