Skip to content

Qtty rot#5

Merged
VPRamon merged 4 commits intomainfrom
qtty-rot
Feb 15, 2026
Merged

Qtty rot#5
VPRamon merged 4 commits intomainfrom
qtty-rot

Conversation

@VPRamon
Copy link
Member

@VPRamon VPRamon commented Feb 15, 2026

This pull request introduces new astronomical reference frames and refactors the rotation APIs to use typed angles, improving type safety and clarity. It also updates related tests and documentation to align with these changes.

Astronomical Frames:

  • Added new geocentric astronomical reference frames: GCRS (Geocentric Celestial Reference System), CIRS (Celestial Intermediate Reference System), and TIRS (Terrestrial Intermediate Reference System) in affn::frames::astro. These are important for precise astronomical and geodetic transformations. [1] [2]

Rotation API Refactoring:

  • Refactored public rotation constructors to require typed angles (qtty::Radians) instead of raw f64 values. This affects Rotation3::from_axis_angle, Rotation3::from_euler_xyz, and Rotation3::from_euler_zxz, enhancing type safety. [1] [2] [3] [4]
  • Introduced new helper methods Rotation3::rx, Rotation3::ry, and Rotation3::rz for constructing rotations around principal axes using typed angles. The previous scalar axis-rotation builders are now internal-only. [1] [2]

Documentation and Examples:

  • Updated documentation and code examples to use the new typed-angle rotation constructors, demonstrating best practices for the new API.

Testing Updates:

Internal Improvements:

  • Internal axis-rotation methods (from_x_rotation, etc.) are now private, with public access provided via the new typed-angle helpers. [1] [2] [3] [4]

@VPRamon VPRamon self-assigned this Feb 15, 2026
@github-actions
Copy link

github-actions bot commented Feb 15, 2026

Code Coverage

Package Line Rate Complexity Health
src.cartesian 98% 0
src.frames 92% 0
src 100% 0
src.ops 100% 0
src.spherical 94% 0
Summary 97% (2110 / 2168) 0

@VPRamon VPRamon merged commit dc310fc into main Feb 15, 2026
5 checks passed
@VPRamon VPRamon deleted the qtty-rot branch February 15, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant