Conversation
added 3 commits
February 13, 2026 15:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new astronomical reference frames and refactors the rotation APIs to use typed angles, improving type safety and clarity. It also updates related tests and documentation to align with these changes.
Astronomical Frames:
GCRS(Geocentric Celestial Reference System),CIRS(Celestial Intermediate Reference System), andTIRS(Terrestrial Intermediate Reference System) inaffn::frames::astro. These are important for precise astronomical and geodetic transformations. [1] [2]Rotation API Refactoring:
qtty::Radians) instead of rawf64values. This affectsRotation3::from_axis_angle,Rotation3::from_euler_xyz, andRotation3::from_euler_zxz, enhancing type safety. [1] [2] [3] [4]Rotation3::rx,Rotation3::ry, andRotation3::rzfor constructing rotations around principal axes using typed angles. The previous scalar axis-rotation builders are now internal-only. [1] [2]Documentation and Examples:
Testing Updates:
rotation.rsandisometry.rsto use the new typed-angle constructors and helpers, ensuring consistency and correctness with the refactored API. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]Internal Improvements:
from_x_rotation, etc.) are now private, with public access provided via the new typed-angle helpers. [1] [2] [3] [4]