feat: Update serde serialization for Ellipsoidal Position to use expl…#7
Merged
feat: Update serde serialization for Ellipsoidal Position to use expl…#7
Conversation
…icit degree suffixes
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on March 20
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
…or Ellipsoidal Position
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the serialization format for ellipsoidal positions to use explicit degree suffixes for longitude and latitude fields, improving clarity and consistency. The most important changes are grouped below:
Serialization format update:
lonandlattolon_degandlat_degin the documentation and implementation, making it clear that these values are always in degrees. (src/ellipsoidal/position_serde.rs) [1] [2]lon_degandlat_deginstead of the previouslonandlat, ensuring backward compatibility and clear error reporting. (src/ellipsoidal/position_serde.rs) [1] [2] [3]Note
Medium Risk
Changes the on-the-wire serialized field names for positions, which can break existing persisted data and client integrations unless migrated.
Overview
Updates
ellipsoidal::Positionserde to emit and requirelon_deg/lat_degfield names (instead oflon/lat), with corresponding updates to documentation and deserialization error messages.Adds a changelog entry noting the serialization breaking change for downstream consumers expecting the old JSON field names.
Written by Cursor Bugbot for commit c719abc. This will update automatically on new commits. Configure here.