Skip to content

feat: Update serde serialization for Ellipsoidal Position to use expl…#7

Merged
VPRamon merged 2 commits intomainfrom
update-serde
Feb 22, 2026
Merged

feat: Update serde serialization for Ellipsoidal Position to use expl…#7
VPRamon merged 2 commits intomainfrom
update-serde

Conversation

@VPRamon
Copy link
Member

@VPRamon VPRamon commented Feb 22, 2026

This pull request updates the serialization format for ellipsoidal positions to use explicit degree suffixes for longitude and latitude fields, improving clarity and consistency. The most important changes are grouped below:

Serialization format update:

  • Changed the serialized field names from lon and lat to lon_deg and lat_deg in the documentation and implementation, making it clear that these values are always in degrees. (src/ellipsoidal/position_serde.rs) [1] [2]
  • Updated error messages and field handling in deserialization to use lon_deg and lat_deg instead of the previous lon and lat, ensuring backward compatibility and clear error reporting. (src/ellipsoidal/position_serde.rs) [1] [2] [3]

Note

Medium Risk
Changes the on-the-wire serialized field names for positions, which can break existing persisted data and client integrations unless migrated.

Overview
Updates ellipsoidal::Position serde to emit and require lon_deg/lat_deg field names (instead of lon/lat), with corresponding updates to documentation and deserialization error messages.

Adds a changelog entry noting the serialization breaking change for downstream consumers expecting the old JSON field names.

Written by Cursor Bugbot for commit c719abc. This will update automatically on new commits. Configure here.

@VPRamon VPRamon self-assigned this Feb 22, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on March 20

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@github-actions
Copy link

github-actions bot commented Feb 22, 2026

Code Coverage

Package Line Rate Complexity Health
src 100% 0
src.cartesian 98% 0
src.frames 93% 0
src.spherical 94% 0
src.ellipsoidal 71% 0
src.ops 100% 0
Summary 95% (2510 / 2646) 0

@VPRamon VPRamon merged commit b300fd2 into main Feb 22, 2026
6 checks passed
@VPRamon VPRamon deleted the update-serde branch February 22, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant