feat: Add Rust-based generator for C++ unit-wrapper headers from unit…#2
Merged
feat: Add Rust-based generator for C++ unit-wrapper headers from unit…#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the build process for generating C++ unit-wrapper headers, switching from a Python script to a Rust-based generator, and makes several code cleanups in the header files. The most significant changes are the introduction of a new Rust crate for code generation, updates to CMake integration, and minor code style improvements in the C++ headers.
Build system and code generation updates:
gen_cpp_units) to generate C++ unit-wrapper headers fromunits.csv, replacing the previous Python-based approach. The Rust crate is defined in the newgen_cpp_units/Cargo.toml. [1] [2] [3] [4]C++ header code cleanups:
include/qtty/literals.hpp, several user-defined literal operator declarations are reformatted to single-line definitions for consistency and readability. [1] [2] [3]include/qtty/literals.hppis adjusted for logical grouping and completeness.include/qtty/units/length.hpp, the formatting of severalUnitTraitsspecializations and type aliases is improved for consistency. [1] [2] [3]