pass type not instance to is_time_variant_term#78
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates PowerOperationsModels’ is_time_variant_term method specializations to match InfrastructureOptimizationModels’ updated interface (passing component types instead of component instances), so time-variant proportional-cost handling continues to dispatch correctly.
Changes:
- Update
is_time_variant_termoverloads for thermal generation costs to accept::Type{<:PSY.ThermalGen}. - Update
is_time_variant_termoverloads for hydro market bid costs to accept::Type{<:PSY.HydroGen}. - Update
is_time_variant_termoverloads for controllable load costs to accept::Type{<:PSY.ControllableLoad}.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/static_injector_models/thermal_generation.jl |
Switches thermal is_time_variant_term dispatch from instances to component types. |
src/static_injector_models/hydro_generation.jl |
Switches hydro MarketBidCost is_time_variant_term dispatch to component types (but needs a corresponding call-site update). |
src/static_injector_models/electric_loads.jl |
Switches controllable load is_time_variant_term dispatch from instances to component types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jd-lara
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point IOM's
is_time_variant_termwas changed to take component types (here). Update POM accordingly.