fix(scan): checkout runner helpers at job_workflow_sha (cross-repo)#33
Merged
Merged
Conversation
…usable)
github.workflow_sha is the CALLER's commit in a reusable-workflow call, so
checking out Sigilix/runner at it fails cross-repo ('not our ref'). Use
github.job_workflow_sha — the reusable workflow's OWN commit — which is valid in
the runner repo both same-repo and cross-repo (unblocks the engine dogfood).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai ignore
@Sigilix ignore
The "Checkout runner helpers" step used
github.workflow_sha, which in a reusable-workflow call resolves to the caller's commit — so checking outSigilix/runnerat it fails cross-repo withfatal: remote error: upload-pack: not our ref(observed breaking the engine dogfood, e.g. Sigilix/sigilix #624/#625).github.job_workflow_shais the reusable workflow's OWN commit, valid in the runner repo both same-repo (CI) and cross-repo (dogfood). One-token fix.