One PairFact repo for ACL code review#7
Open
lihebi wants to merge 16 commits into
Open
Conversation
5 tasks
Collaborator
Author
|
Update: add classification results in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the up-to-date code & results for PairFact, including factcc,qags,frank datasets. It is all-in-one repo ready for ACL code review. Changes in this PR:
TODO: anonymize it.
The important file is
factcc.pyandeval.py(the entry point). Other files are mostly copied from DocAsRef_0 repo.Current results:
Note: the pooled-level collect all results for all docIds, and compute correlations for the entire vectors. The reason is qags and factcc has only one system per docID, thus cannot do summary-level (stats.scipy.correlation throws error on vectors of size 1).
Additional missing results (currently running):