Conversation
nilesh-simform
commented
Jul 16, 2024
- added support for external URL
5067cc0 to
74f94bc
Compare
|
@nilesh-simform Can you please check if we are downloading audio files every time, or is it doing caching and taking file paths from cached data for the same file a second time? If it is cached, is the downloaded media permanent or not? If yes, can we pass a file path to which we can download audio? |
dc8dd51 to
ac3e188
Compare
Yes, it is downloading audio temporarily every time, I have also added mechanism to remove temporary file on unmounting of waveform |
This is fine for smaller files but for large files this does not seem right to me. @mukesh-simform Can you please check? |
|
@kuldip-simform @nilesh-simform when will u merge these changes i badly need url support |
4bf11fa to
d1df669
Compare
|
@nilesh-simform I hope you are fine when will you merge flatlist issues changes in master from develop? |
c34b0f7 to
9cd8bec
Compare
9cd8bec to
631e0bb
Compare
|
@kuldip-simform @nilesh-simform please merge these changes, I also need url support |
|
@nilesh-simform Please merge this, I need external url support for the waveform. thanks |
|
@mukesh-simform kindly review this merge, I need the external url support for the waveform asap, thanks. |
57e2faa to
57f956d
Compare
|
@mukesh-simform @nilesh-simform Still waiting for the successful merge guys! :| |
|
@nilesh-simform @mukesh-simform guys can you let us know till when can we expect this PR to be merged? Will it still take considerable time? Please let us know, thanks! :) |
|
@moeezally @SyedZawwarAhmed @hamzadar2013 If you need it urgently,
It should work as a temporary solution until this is merged. I tested it. |
|
For any one need support for remote url urgently, there is a workaround, you can check if the url is remote, if so download it and use the local url and if not remote use the provided url |
|
Is it possible to add .wav file support too @nilesh-simform ? |
57f956d to
49bf4dd
Compare
a0147be to
b9b682a
Compare
b9b682a to
bf827f8
Compare
|
@kuldip-simform @nilesh-simform please merge these changes, I also need url support |
|
@nilesh-simform are you cleaning the cache? i m not sure but im not finding this part of code. |
|
@nilesh-simform @kuldip-simform @nilesh-simform I did found a provisional solution. I took the liberty of creating a separate code based on yours. I solved the following problems
Remember that my intention is not to harm or copy the project, but to contribute :) If you need another contributor, I'm available. |