Add Encoder.Convert(ReadOnlySpan<char>, Span<byte>) polyfill#564
Merged
SimonCropp merged 1 commit intoJun 27, 2026
Merged
Conversation
Polyfills the span-based Encoder.Convert overload (introduced in netcoreapp2.1/netstandard2.1) for older targets, with unsafe pointer and safe array-based variants. The safe fallback matches BCL semantics exactly rather than using StringStream's input cap, since a general consumer expects exact charsUsed parity. Qualify the unqualified Convert.* calls in Base64Polyfill and EnumPolyfill to System.Convert.* to avoid collision with the new Polyfill.Convert extension method.
SimonCropp
deleted the
Add-Encoder.Convert(ReadOnlySpan-char-,-Span-byte-)-polyfill
branch
This was referenced Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polyfills the span-based Encoder.Convert overload (introduced in netcoreapp2.1/netstandard2.1) for older targets, with unsafe pointer and safe array-based variants. The safe fallback matches BCL semantics exactly rather than using StringStream's input cap, since a general consumer expects exact charsUsed parity.
Qualify the unqualified Convert.* calls in Base64Polyfill and EnumPolyfill to System.Convert.* to avoid collision with the new Polyfill.Convert extension method.