Skip to content
This repository was archived by the owner on Dec 30, 2024. It is now read-only.

New build scripts#53

Open
DEATHB4DEFEAT wants to merge 7 commits into
masterfrom
new-build-scripts
Open

New build scripts#53
DEATHB4DEFEAT wants to merge 7 commits into
masterfrom
new-build-scripts

Conversation

@DEATHB4DEFEAT

@DEATHB4DEFEAT DEATHB4DEFEAT commented Mar 21, 2023

Copy link
Copy Markdown
Member

About the PR

Better build scripts, batch ones have been tested
Shell ones need testing (@CharcoalGungan) but should be mostly fine

@github-actions github-actions Bot added the Status: Needs Review Someone please review this label Mar 21, 2023
@DEATHB4DEFEAT DEATHB4DEFEAT added Priority: 3-Medium Needs to be resolved at some point Status: Help Wanted Extra attention is needed Status: Needs Review Someone please review this Size: Very Small For especially small issues/PRs and removed Status: Needs Review Someone please review this labels Mar 21, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these two files in particular aren't really needed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these two files in particular aren't really needed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these two files in particular aren't really needed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these two files in particular aren't really needed.

@CharcoalGungan CharcoalGungan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your linux scripts are all fucked lemme fix em

@CharcoalGungan CharcoalGungan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it be funny as all hell i approve my own changes : )

@DEATHB4DEFEAT

Copy link
Copy Markdown
Member Author

it be funny as all hell i approve my own changes : )

I am going to implement the "latest one to push cannot approve changes" rule just because of this

Comment thread Scripts/sh/runBuildAll.sh
Comment on lines +8 to +9
echo "will run both server and client in the same terminal so will give you both outputs at once"
echo "dont mind fatl error relating to port 1212 does not seem to change anything"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get this retested to make sure it wasn't just like, a single time thing? I really have doubts that this is a real issue.

@Pspritechologist

Copy link
Copy Markdown
Member

Awaiting

@Pspritechologist Pspritechologist removed the Status: Needs Review Someone please review this label May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Priority: 3-Medium Needs to be resolved at some point Size: Very Small For especially small issues/PRs Status: Do Not Merge Do not merge Status: Help Wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants