test(autogram): Revamp engine tests#418
Merged
ValerianRey merged 21 commits intomainfrom Sep 15, 2025
Merged
Conversation
…valence_autograd_autogram`. The tests of autogram are not independent from autojac because we still have the full forward_backward phase integration test.
PierreQuinton
added
cc: test
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
ValerianRey
reviewed
Sep 12, 2025
Contributor
ValerianRey
left a comment
ValerianRey
left a comment
There was a problem hiding this comment.
I think these changes are very good. Just need to address the comments + fix the tolerance for MacOS.
…grad_autojac_and_autogram_speed
It's a form of backward pass so I think it's fine to have it here + it's one fewer file.
Also reduce batch sizes, otherwise too high cuda memory usage. GPU has lost his will to live after so much time spent rendering graphics for world of warcraft I guess.
ValerianRey
changed the title
Contributor
|
Jokes aside, I think we had a garbage collection issue before b22dcb0. Should be fixed now. Completely unrelated to this PR so I might extract in another one, but flemme. |
Contributor
Author
|
Flemme LGTM. Anymore things that come to mind for this PR? |
Contributor
We need to adjust the tolerances so that tests pass on MacOS |
This should make the test pass even on MacOS
ValerianRey
changed the title
* Move / rename functions * Improve docstrings * Reformat
Contributor
|
@PierreQuinton I Improved a few other things FYI. Merging this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.