refactor(autojac): Remove reshaping to/from matrix in Jac#420
Merged
ValerianRey merged 3 commits intomainfrom Sep 14, 2025
Merged
refactor(autojac): Remove reshaping to/from matrix in Jac#420ValerianRey merged 3 commits intomainfrom
Jac#420ValerianRey merged 3 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Contributor
PierreQuinton
left a comment
There was a problem hiding this comment.
I don't remember why we have all this things with chunks rather than using chunk_size of vmap (For the chunk_size=1 I get it). I guess there was a good reason to have that so LGTM.
PierreQuinton
approved these changes
Sep 13, 2025
Contributor
Author
2 reasons IIRC:
|
Contributor
|
Right, this is quite nasty. Good thing we have one memory for two. I think this can be merged, unless we should test some more? |
Contributor
Author
|
Yes ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jac#419Since the first commit also made
_get_vjpbe the same between Grad and Jac, I also factorized them.