fix(autogram): Remove reference cycles#424
Merged
PierreQuinton merged 5 commits intomainfrom Sep 19, 2025
Merged
Conversation
* Use a dedicated Hook class for readability and improved debugging * Use BoolRef so that we can have a pointer to the boolean value in the Hook without having a pointer to the ModuleHookManager in the Hook (which is a reference cycle). * Use the module given as input to Hook.__call__ rather than the module provided to hook_module. This avoids having to store a reference to the module in its hook (which is a reference cycle).
* Instead of using non-local variables, make them take these variables as input to forward * This seems more standard practice, and fixes a reference cycle issue
* This solves the last reference cycle issue
* Remove garbage_collect marker * Remove garbage_collect_if_marked fixture This is not needed anymore since the garbage collector's job is much easier now
ValerianRey
added
cc: fix
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
PierreQuinton
approved these changes
Sep 18, 2025
Contributor
PierreQuinton
left a comment
PierreQuinton
left a comment
There was a problem hiding this comment.
LGTM if typing is prohibitively annoying.
PierreQuinton
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There will be some conflicts with #411 but I think we still want to merge this, and basically re-code this from scratch in #411 (it's quite easy now that we know what to do, maybe 1h work).