refactor(autogram): Switch to ComputeModuleJacobians#452
Conversation
…f the module rather than providing them to the GramianAccumulator directly. Rename the class to `ComputeModuleJacobians` to better reflect its role.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
|
todos are outdated right? |
|
I think this PR should be grouped with the other PRs that you have in mind, so that we can get impactful changes together with this. |
No, I just put them in the wrong PR.
Possibly, but this is a strict improvement that is pretty atomic and independent of anything I have in mind so far (but typically a requirement), it makes it easy to review. Whatever you prefer. |
Yes I understand better now and I agree. |
AccumulateJacobianreturn the Jacobian w.r.t. the parameters of the module rather than providing them to theGramianAccumulatordirectly.AccumulateJacobiantoComputeModuleJacobiansto better reflect its role.