Skip to content

test: Add dtype setting#496

Merged
ValerianRey merged 2 commits intomainfrom
add-dtype-setting
Dec 21, 2025
Merged

test: Add dtype setting#496
ValerianRey merged 2 commits intomainfrom
add-dtype-setting

Conversation

@ValerianRey
Copy link
Copy Markdown
Contributor

@ValerianRey ValerianRey commented Dec 21, 2025

With this, we can run tests on either float32 (the default) or float64.

To run with float64, simply set the environement variable PYTEST_TORCH_DTYPE to float64.

Next steps:

  • Slightly increase test tolerance in UPGrad and DualProj: with the current tolerances they fail on my GPU on float64.
  • Test this in the CI? I don't think we need to test every OS and python version for this, 1 should be enough.

@ValerianRey ValerianRey added the cc: test Conventional commit type for changes to tests. label Dec 21, 2025
@ValerianRey ValerianRey self-assigned this Dec 21, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ValerianRey ValerianRey merged commit 8ed91c7 into main Dec 21, 2025
20 checks passed
@ValerianRey ValerianRey deleted the add-dtype-setting branch January 28, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc: test Conventional commit type for changes to tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant