Merged
Conversation
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
b2adb58 to
95a237e
Compare
…ng entire test files
…f ignoring entire test files" This reverts commit fff23ae.
Contributor
Author
|
@PierreQuinton This seems to work. It was mostly vibe-coded so let's be careful. |
Contributor
Author
|
@PierreQuinton seems ok to merge? |
Contributor
|
Not super qualified, but this does look like a strict improvement, so in my opinion, we can meege and worst case we'll improve later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, some information about how to reduce redundancy in ci:
&anchorwhen defining it,*anchorwhen reusing it)on:key at the beginning). But they're made to be used by other actions or workflows either from the same repo or from a different repo.The issue with anchors is that they cannot be shared between files. So it's not really suitable for things like setting up uv and installing dependencies.
The issue with actions is that it's a bit more verbose (one line per parameter) and it adds one folder + the
action.ymlfile for each of them (it's not allowed to just haveaction-name.ymloutside of any folder). Another issue is that we need to checkout the repo before being able to use an action that is defined locally. So we cannot factorize theCheckout repositoryaction.This PR changes quite a few things in the CI:
Note that this significantly reduces the number of tests to run, so it should reduce the chance that one of the runners is queued and slows the CI down.