Skip to content

refactor(linalg): Create _linalg package#520

Merged
PierreQuinton merged 5 commits intomainfrom
improve-psd-matrix-handling
Jan 16, 2026
Merged

refactor(linalg): Create _linalg package#520
PierreQuinton merged 5 commits intomainfrom
improve-psd-matrix-handling

Conversation

@PierreQuinton
Copy link
Copy Markdown
Contributor

@PierreQuinton PierreQuinton commented Jan 16, 2026

  • Create _linalg package
  • Factorize computation of Gramian to _linalg
  • Move Matrix and PSDMatrix to _linalg
  • Properly type gramians as PSDMatrix
  • Add assert_psd_matrix
  • Test that compute_gramian returns a psd_matrix

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/torchjd/_linalg/__init__.py 100.00% <100.00%> (ø)
src/torchjd/_linalg/gramian.py 100.00% <100.00%> (ø)
src/torchjd/_linalg/matrix.py 100.00% <100.00%> (ø)
src/torchjd/aggregation/_aggregator_bases.py 100.00% <100.00%> (ø)
src/torchjd/aggregation/_aligned_mtl.py 100.00% <100.00%> (ø)
src/torchjd/aggregation/_cagrad.py 100.00% <100.00%> (ø)
src/torchjd/aggregation/_constant.py 100.00% <100.00%> (ø)
src/torchjd/aggregation/_dualproj.py 100.00% <100.00%> (ø)
src/torchjd/aggregation/_flattening.py 100.00% <100.00%> (ø)
src/torchjd/aggregation/_imtl_g.py 100.00% <100.00%> (ø)
... and 15 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@claude
Copy link
Copy Markdown

claude bot commented Jan 16, 2026


Code review

No issues found. Checked for bugs and CLAUDE.md compliance.


Copy link
Copy Markdown
Contributor

@ValerianRey ValerianRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you can merge if this is complete.

@PierreQuinton PierreQuinton changed the title Improve psd matrix handling refactor(linalg): Create _linalg package Jan 16, 2026
@PierreQuinton PierreQuinton merged commit b280b10 into main Jan 16, 2026
16 checks passed
@PierreQuinton PierreQuinton added the cc: refactor Conventional commit type for any refactoring, not user-facing, and not typing or perf improvements label Jan 16, 2026
@PierreQuinton PierreQuinton deleted the improve-psd-matrix-handling branch January 16, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc: refactor Conventional commit type for any refactoring, not user-facing, and not typing or perf improvements package: linalg

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants