Skip to content

refactor(autojac): Use TypeGuard for TensorWithJac#521

Merged
ValerianRey merged 2 commits intomainfrom
use-type-guard-for-tensor-with-jac
Jan 19, 2026
Merged

refactor(autojac): Use TypeGuard for TensorWithJac#521
ValerianRey merged 2 commits intomainfrom
use-type-guard-for-tensor-with-jac

Conversation

@PierreQuinton
Copy link
Copy Markdown
Contributor

@ValerianRey You'll love this. We could have a label typing for the PRs (or maybe not).

@PierreQuinton PierreQuinton added package: autojac cc: refactor Conventional commit type for any refactoring, not user-facing, and not typing or perf improvements cc: style Conventional commit type for minor style changes. labels Jan 19, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/torchjd/autojac/_accumulation.py 100.00% <100.00%> (ø)
src/torchjd/autojac/_jac_to_grad.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@claude
Copy link
Copy Markdown

claude bot commented Jan 19, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Co-authored-by: Pierre Quinton <pierre.quinton@epfl.ch>
@ValerianRey ValerianRey removed the cc: style Conventional commit type for minor style changes. label Jan 19, 2026
Copy link
Copy Markdown
Contributor

@ValerianRey ValerianRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, really nice.

@ValerianRey
Copy link
Copy Markdown
Contributor

We could have a label typing for the PRs (or maybe not).

Yeah arguably we could have several labels replacing the different kinds of refactors that we usually do. For instance perf or typing. But also I think it's nice to stick to conventional commit names, and perf is arguably one of them but not typing I think.

@ValerianRey ValerianRey merged commit b0adff6 into main Jan 19, 2026
16 checks passed
@ValerianRey ValerianRey deleted the use-type-guard-for-tensor-with-jac branch January 19, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc: refactor Conventional commit type for any refactoring, not user-facing, and not typing or perf improvements package: autojac

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants