feat(aggregation) Add scale_mode parameter to AlignedMTL#527
Merged
ValerianRey merged 5 commits intoSimplexLab:mainfrom Jan 23, 2026
Merged
feat(aggregation) Add scale_mode parameter to AlignedMTL#527ValerianRey merged 5 commits intoSimplexLab:mainfrom
AlignedMTL#527ValerianRey merged 5 commits intoSimplexLab:mainfrom
Conversation
Expose median and rmse scaling modes for the balance transformation to match original behavior while keeping min as default.
Add coverage for median/rmse modes and invalid scale_mode handling.
Document the new scale_mode parameter for AlignedMTL and AlignedMTLWeighting.
for more information, see https://pre-commit.ci
Contributor
Author
|
CI checks may show as pending until a maintainer approves workflows for this first-time contributor fork. Local unit tests passed (see PR body). |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Contributor
|
Thanks for the PR, it's really clean and ready to merge now! I just changed tests slightly, otherwise some of them fail when testing on cuda (on my laptop's GeForce GTX 1080 gpu, something that the CI cannot test automatically). |
ValerianRey
changed the title
AlignedMTL
ValerianRey
added
cc: feat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scale_modeparameter toAlignedMTLandAlignedMTLWeighting.min(default),median, andrmsescaling for the balance transformation.Tests
UV_NO_SYNC=1 uv run pytest tests/unit(2604 passed, 63 skipped, 33 xfailed)Notes
This PR supersedes #526, which was auto-closed after the head repository was deleted (by mistake, sorry).