refactor(aggregation): Add gramian_weighting field#533
Merged
ValerianRey merged 5 commits intomainfrom Jan 28, 2026
Merged
Conversation
ValerianRey
added
package: aggregation
cc: refactor
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
ValerianRey
changed the title
gramian_weighting field
PierreQuinton
approved these changes
Jan 28, 2026
Contributor
PierreQuinton
left a comment
PierreQuinton
left a comment
There was a problem hiding this comment.
LGTM. Arguably, adding a changlog entry would notify some users that they can do that now (but I don't really care either way is fine).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some typing problems and it's also much cleaner for users that want to hook the gramian weighting. I deliberately avoided calling it psd_weighting because it's somewhat user-facing (and we currently never really explain what psd is).
It's technically not a breaking change because
aggregator.weighting.weightingstill exists. So I think we don't have to add a changelog entry for this.