refactor(linalg): Add missing overload to compute_gramian#540
Merged
ValerianRey merged 1 commit intomainfrom Jan 29, 2026
Merged
refactor(linalg): Add missing overload to compute_gramian#540ValerianRey merged 1 commit intomainfrom
compute_gramian#540ValerianRey merged 1 commit intomainfrom
Conversation
Contributor
Author
|
@PierreQuinton FYI (you were right about this in your PR). |
compute_gramian
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Contributor
|
@ValerianRey Any reason why the CI passed on this? I would have expected mypy to be unhappy there. Is there something we can do to make it stricter? Or is it just that mypy doesn't check overloads at all? |
Contributor
Author
The reason is that we don't currently ever use Also, mypy isn't checked in tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought we could remove it, but this overload is actually necessary. Otherwise we get a Pylance error when we don't match the other overloads.