typing(aggregation): Fix Literal attribute typing#549
Merged
ValerianRey merged 2 commits intomainfrom Feb 2, 2026
Merged
Conversation
Contributor
ValerianRey
commented
Feb 1, 2026
ValerianRey
commented
- typing(aggregation): Add SUPPORTED_SOLVER type alias
- Fix Literal automatic type widening
When an attribute is a Literal["something", "something else"], it's important to type both the parameter value of the constructor and the attribute itself in the constructor. Before, we only typed the parameter value. When doing that, the attribute is considered as a string that is initialized at "something" or "something else", but that may change in the future to "even something else". So it's just considered as a string in other methods, not as a Literal["something", "something else"]. This only happens with Literals of strings, so we don't need to do that for every attribute. This fixes 3 errors reported by Pylance. Also create TypeAlias SUPPORTED_SCALE_MODE (forgot to separate commits)
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
ValerianRey
added
the
cc: typing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.