ci: Switch from flake8, isort and black to ruff#554
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
…able to push TODOs to Github and detect them there.
This reverts commit f94b3a9.
|
This is a bit annoying, we can't make the CI fail on TODOs while it work on local because we are using the precommit.ci app to do the check instead of using EDIT: This is what I did in the commits following this one, if we accept this, then we need to remove |
The reason we used strict=False was only that it's the default and it's thus shorter to write. If we're forced to specify the `strict` parameter, let's use `True`.
I think what you did is perfect: having ruff run both in pre-commit hooks (so that we instantly block comitting if some formatting is wrong) and having it in the github action, so that we have the nicer formatting (mostly for when we somehow have pre-commit not installed because of an incomplete reinstallation, or for new contributors). |
|
Really nice, LGTM Even if it's just 1 second, it's noticeably faster to run the hooks locally. |
Structural changes:
Code changes to adapt to ruff: