Fix SonarQube Coverage Reporting After Gradle 9.4 Upgrade#1694
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repository’s SonarQube configuration to restore coverage reporting after the Gradle 9.4 upgrade, primarily by centralizing Sonar settings and making binary output discovery more resilient across modules.
Changes:
- Refactors
build-logic/sonarqube.gradleto set the Jacoco XML report path and dynamically locate compiled class directories forsonar.java.binaries. - Removes the module-local SonarQube skip configuration from
:infra:resources, relying on centralized Sonar configuration instead. - Updates multiple Hilt-injected
Contextconstructor parameters to use the@param:ApplicationContextuse-site target.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| testing/data-generator/src/main/java/com/simprints/feature/datagenerator/events/SqlEventTemplateLoader.kt | Adjusts Hilt qualifier use-site target for injected Context. |
| infra/ui-base/src/main/java/com/simprints/infra/uibase/camera/qrscan/CameraHelper.kt | Adjusts Hilt qualifier use-site target for injected Context. |
| infra/security/src/main/java/com/simprints/infra/security/root/RootManagerImpl.kt | Adjusts Hilt qualifier use-site target for injected Context. |
| infra/resources/build.gradle.kts | Removes module-local SonarQube skip block (skip now handled centrally). |
| infra/network/src/main/java/com/simprints/infra/network/url/BaseUrlProviderImpl.kt | Adjusts Hilt qualifier use-site target for injected Context. |
| infra/network/src/main/java/com/simprints/infra/network/httpclient/BuildOkHttpClientUseCase.kt | Adjusts Hilt qualifier use-site target for injected Context. |
| infra/network/src/main/java/com/simprints/infra/network/connectivity/ConnectivityManagerWrapper.kt | Adjusts Hilt qualifier use-site target for injected Context. |
| infra/events/src/main/java/com/simprints/infra/events/event/local/EventDatabaseFactory.kt | Adjusts Hilt qualifier use-site target for injected Context. |
| infra/event-sync/src/main/java/com/simprints/infra/eventsync/permission/CommCarePermissionChecker.kt | Adjusts Hilt qualifier use-site target for injected Context. |
| infra/event-sync/src/main/java/com/simprints/infra/eventsync/event/commcare/CommCareEventDataSource.kt | Adjusts Hilt qualifier use-site target for injected Context. |
| infra/enrolment-records/room-store/src/main/java/com/simprints/infra/enrolment/records/room/store/SubjectsDatabaseFactory.kt | Adjusts Hilt qualifier use-site target for injected Context. |
| infra/config-store/src/main/java/com/simprints/infra/config/store/local/migrations/DeviceConfigSharedPrefsMigration.kt | Adjusts Hilt qualifier use-site target for injected Context. |
| infra/config-store/src/main/java/com/simprints/infra/config/store/LastCallingPackageStore.kt | Adjusts Hilt qualifier use-site target and minor formatting update. |
| fingerprint/infra/scanner/src/main/java/com/simprints/fingerprint/infra/scanner/tools/BatteryLevelChecker.kt | Adjusts Hilt qualifier use-site target for injected Context. |
| fingerprint/capture/src/main/java/com/simprints/fingerprint/capture/screen/PlayAudioBeepUseCase.kt | Adjusts Hilt qualifier use-site target for injected Context. |
| feature/dashboard/src/test/java/com/simprints/feature/dashboard/tools/di/FakeCoreModule.kt | Simplifies WorkManager provider (no longer requires @ApplicationContext parameter). |
| face/infra/simface/src/main/java/com/simprints/face/infra/simface/initialization/SimFaceInitializer.kt | Adjusts Hilt qualifier use-site target for injected Context. |
| face/capture/src/main/java/com/simprints/face/capture/usecases/IsUsingAutoCaptureUseCase.kt | Adjusts Hilt qualifier use-site target for injected Context. |
| build-logic/sonarqube.gradle | Central Sonar configuration updated: sets android variant, Jacoco XML path, and dynamically resolves compiled binaries directories. |
| build-logic/convention/src/main/kotlin/PipelineSonarConventionPlugin.kt | Removes the now-redundant Sonar convention plugin implementation. |
02fc112 to
4c70993
Compare
4c70993 to
fdec1a9
Compare
|
luhmirin-s
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
Will be released in: 2026.3.0
Root cause analysis (for bugfixes only)
First known affected version: 2026.3.0
Notable changes
Testing guidance
Additional work checklist