fix(changelog): make react-select dropdown legible in dark mode#1090
Open
gkLeo wants to merge 1 commit into
Open
fix(changelog): make react-select dropdown legible in dark mode#1090gkLeo wants to merge 1 commit into
gkLeo wants to merge 1 commit into
Conversation
|
@gkLeo is attempting to deploy a commit to the Sitecore Technical Marketing Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Added dark-mode CSS overrides for react-select in src/styles/global.css to fix dropdown contrast on
/changelog. The rules map react-select parts (control, menu, options, multi-value, indicators) to existing theme tokens so they respect the dark theme.The
/changelogpage's Products and Changes dropdowns usereact-selectwith its default light theme, making them illegible in dark mode. The CSS fix ensures the dropdown respects the site's dark theme and remains readable.Related issue: #1089
How Has This Been Tested?
To verify the dark-mode fix, I tested the CSS changes directly on the live site using browser DevTools:
Opened the live changelog page (
https://developers.sitecore.com/changelog) and switched to Dark theme.Opened DevTools → Console and injected the dark-mode CSS overrides:
Clicked the Products and Changes dropdowns and verified:
Switched back to Light theme and verified the dropdown still looks correct (no regression).
Removed the test styles to confirm the original issue reappears:
Types of changes
/datadirectory or other markdown files)Checklist:
/public/imagesfolder that need to be migrated to Sitecore DAM