feat(ui): improve UX with Pin mode, scrollable alerts, and sparkline enhancements#70
Merged
Merged
Conversation
|
@TakahashiMinato is attempting to deploy a commit to the Sitoi Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces several UI/UX improvements to ClashBar, porting and adapting fixes from the
fix/uibranch to the current codebase structure.1. Pin Mode (Window Stickiness)
Introduces a "Pin" functionality to keep the main application window visible even when clicking outside or switching spaces.
pin/unpin).collectionBehaviorto.canJoinAllSpacesand disableshidesOnDeactivate.2. Scrollable NSAlerts
Improves the presentation of long text in system alerts (e.g., configuration validation errors or remote import logs).
NSAlert+Scrollableto wrap informative text in a dynamically sizedNSScrollView.3. Traffic Sparkline Optimization
Refines the real-time traffic chart for better visual consistency.
4. Localization
ui.action.pinandui.action.unpinstrings for both English and Simplified Chinese.Changes
NSAlert+Scrollable.swiftextension.AppViewModelfor state management andAppViewModel+Alertsfor modal logic.MenuBarHeaderView,TrafficSparklineView, andStatusItemController.Localizable.stringsfor multiple languages.Verification Results
make build.