Skip to content

Improve image/file input validation and add hoist prop to RLSelect #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pzocchi merged 2 commits into from
Jan 19, 2026
Merged

Improve image/file input validation and add hoist prop to RLSelect #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8c8195
Improve validation on file/image input
pzocchi Jan 16, 2026
6c36495
Add hoist prop to RLSelect with true as default
pzocchi Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/RLFileInput/RLFileInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export const RLFileInput = forwardRef<RLFileInputRef, RLFileInputProps>(
const { errorMessage, isValid, validate } = useValidation({ rules, externalError: error })

useEffect(() => {
if (value !== undefined) {
if (value != null) {
validate(value)
}
}, [value, validate])
Expand Down
2 changes: 1 addition & 1 deletion src/components/RLImageUpload/RLImageUpload.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const RLImageUpload = forwardRef<RLImageUploadRef, RLImageUploadProps>(
const { errorMessage, isValid, validate } = useValidation({ rules, externalError: error })

useEffect(() => {
if (value !== undefined) {
if (value != null) {
validate(value)
}
}, [value, validate])
Expand Down
3 changes: 2 additions & 1 deletion src/components/RLSelect/RLSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export const RLSelect = forwardRef<RLSelectRef, RLSelectProps>(
pill,
filled,
placement = 'bottom',
hoist = true,
helpText,
label,
options = [],
Expand Down Expand Up @@ -173,7 +174,7 @@ export const RLSelect = forwardRef<RLSelectRef, RLSelectProps>(
<div className={`relative ${className ?? ''}`}>
<SlSelect
className={combinedClassName}
hoist
hoist={hoist}
value={templateValue}
name={name}
defaultValue={defaultValue}
Expand Down
1 change: 1 addition & 0 deletions src/components/RLSelect/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ export interface RLSelectProps {
pill?: boolean
filled?: boolean
placement?: 'top' | 'bottom'
hoist?: boolean
helpText?: string
label?: string
options: RLSelectOptionType[]
Expand Down