refactor(ocaml-jsonrpc-tp/python): use pydantic BaseModel for Err + Resp types#282
Open
jhaag-skylabs-ai wants to merge 18 commits into
Open
refactor(ocaml-jsonrpc-tp/python): use pydantic BaseModel for Err + Resp types#282jhaag-skylabs-ai wants to merge 18 commits into
BaseModel for Err + Resp types#282jhaag-skylabs-ai wants to merge 18 commits into
Conversation
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | e5c342a |
| fmdeps/BRiCk/ | main | b79c734 |
| fmdeps/auto/ | main | ffda14f |
| fmdeps/auto-docs/ | main | 9f57097 |
| bluerock/NOVA/ | skylabs-proof | 996d600 |
| bluerock/bhv/ | skylabs-main | b1ca30d |
| fmdeps/brick-libcpp/ | main | dc9818e |
| fmdeps/ci/ | main | 7712f8c |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | 262fb04 |
| fmdeps/fm-tools/ | main | 430933c |
| psi/protos/ | main | 8fe3e7c |
| psi/backend/ | main | 2a8240c |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 62ed81e |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 7d620c1 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122840.0 | 122840.0 | -0.0 | total |
| -0.00% | 22632.7 | 22632.7 | -0.0 | ├ translation units |
| +0.00% | 100207.4 | 100207.4 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122840.0 | 122840.0 | -0.0 | total |
| -0.00% | 22632.7 | 22632.7 | -0.0 | ├ translation units |
| +0.00% | 100207.4 | 100207.4 | +0.0 | └ proofs and tests |
Merged
23 tasks
Janno
reviewed
Mar 5, 2026
Contributor
Janno
left a comment
Janno
left a comment
There was a problem hiding this comment.
Nothing much to add to Gregory's comments. The overall change looks good to me.
It might make sense to make the two classes final so that we can more easily switch to ty if we ever want to do that. (See https://skylabs-ai.atlassian.net/wiki/spaces/FM/pages/639336451/Python+Type+Checkers#Correct-isinstance()-behavior)
jhaag-skylabs-ai
force-pushed
the
ocaml-jsonrpc-tp/python/use-pydantic
branch
from
df6602f to
ac7a598
Compare
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | e5c342a |
| fmdeps/BRiCk/ | main | b79c734 |
| fmdeps/auto/ | main | ffda14f |
| fmdeps/auto-docs/ | main | 9f57097 |
| bluerock/NOVA/ | skylabs-proof | 996d600 |
| bluerock/bhv/ | skylabs-main | b1ca30d |
| fmdeps/brick-libcpp/ | main | dc9818e |
| fmdeps/ci/ | main | 7712f8c |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | 262fb04 |
| fmdeps/fm-tools/ | main | 430933c |
| psi/protos/ | main | 8fe3e7c |
| psi/backend/ | main | 196a186 |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 62ed81e |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 7d620c1 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122840.0 | 122840.0 | -0.0 | total |
| -0.00% | 22632.7 | 22632.7 | -0.0 | ├ translation units |
| +0.00% | 100207.4 | 100207.4 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122840.0 | 122840.0 | -0.0 | total |
| -0.00% | 22632.7 | 22632.7 | -0.0 | ├ translation units |
| +0.00% | 100207.4 | 100207.4 | +0.0 | └ proofs and tests |
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | e5c342a |
| fmdeps/BRiCk/ | main | b79c734 |
| fmdeps/auto/ | main | ffda14f |
| fmdeps/auto-docs/ | main | 9f57097 |
| bluerock/NOVA/ | skylabs-proof | 996d600 |
| bluerock/bhv/ | skylabs-main | 8d08b1c |
| fmdeps/brick-libcpp/ | main | dc9818e |
| fmdeps/ci/ | main | 7712f8c |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | 262fb04 |
| fmdeps/fm-tools/ | main | 430933c |
| psi/protos/ | main | 8fe3e7c |
| psi/backend/ | main | 196a186 |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 62ed81e |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 7d620c1 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.00% | 122903.6 | 122903.6 | +0.0 | total |
| +0.00% | 22632.5 | 22632.5 | +0.0 | ├ translation units |
| +0.00% | 100271.1 | 100271.1 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.00% | 122903.6 | 122903.6 | +0.0 | total |
| +0.00% | 22632.5 | 22632.5 | +0.0 | ├ translation units |
| +0.00% | 100271.1 | 100271.1 | +0.0 | └ proofs and tests |
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | e5c342a |
| fmdeps/BRiCk/ | main | b79c734 |
| fmdeps/auto/ | main | ffda14f |
| fmdeps/auto-docs/ | main | 9f57097 |
| bluerock/NOVA/ | skylabs-proof | 996d600 |
| bluerock/bhv/ | skylabs-main | 8d08b1c |
| fmdeps/brick-libcpp/ | main | dc9818e |
| fmdeps/ci/ | main | 7712f8c |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | 262fb04 |
| fmdeps/fm-tools/ | main | 430933c |
| psi/protos/ | main | 8fe3e7c |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 62ed81e |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 7d620c1 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.00% | 122903.6 | 122903.6 | +0.0 | total |
| +0.00% | 22632.5 | 22632.5 | +0.0 | ├ translation units |
| +0.00% | 100271.1 | 100271.1 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.00% | 122903.6 | 122903.6 | +0.0 | total |
| +0.00% | 22632.5 | 22632.5 | +0.0 | ├ translation units |
| +0.00% | 100271.1 | 100271.1 | +0.0 | └ proofs and tests |
gmalecha-at-skylabs
previously requested changes
Mar 5, 2026
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | e5c342a |
| fmdeps/BRiCk/ | main | b79c734 |
| fmdeps/auto/ | main | ffda14f |
| fmdeps/auto-docs/ | main | 9f57097 |
| bluerock/NOVA/ | skylabs-proof | 996d600 |
| bluerock/bhv/ | skylabs-main | 8d08b1c |
| fmdeps/brick-libcpp/ | main | dc9818e |
| fmdeps/ci/ | main | 7712f8c |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | 262fb04 |
| fmdeps/fm-tools/ | main | 430933c |
| psi/protos/ | main | 8fe3e7c |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 62ed81e |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 7d620c1 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.00% | 122903.5 | 122903.5 | +0.0 | total |
| +0.00% | 22632.4 | 22632.4 | +0.0 | ├ translation units |
| +0.00% | 100271.1 | 100271.1 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.00% | 122903.5 | 122903.5 | +0.0 | total |
| +0.00% | 22632.4 | 22632.4 | +0.0 | ├ translation units |
| +0.00% | 100271.1 | 100271.1 | +0.0 | └ proofs and tests |
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | e5c342a |
| fmdeps/BRiCk/ | main | b79c734 |
| fmdeps/auto/ | main | ffda14f |
| fmdeps/auto-docs/ | main | 9f57097 |
| bluerock/NOVA/ | skylabs-proof | 996d600 |
| bluerock/bhv/ | skylabs-main | 8d08b1c |
| fmdeps/brick-libcpp/ | main | dc9818e |
| fmdeps/ci/ | main | 7712f8c |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | 262fb04 |
| fmdeps/fm-tools/ | main | 430933c |
| psi/protos/ | main | 8fe3e7c |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 62ed81e |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 7d620c1 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122903.6 | 122903.5 | -0.0 | total |
| -0.00% | 22632.4 | 22632.5 | -0.0 | ├ translation units |
| +0.00% | 100271.1 | 100271.1 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122903.6 | 122903.5 | -0.0 | total |
| -0.00% | 22632.4 | 22632.5 | -0.0 | ├ translation units |
| +0.00% | 100271.1 | 100271.1 | +0.0 | └ proofs and tests |
Contributor
Author
|
@gmalecha-at-skylabs this is ready for another review. Please take a close look at |
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | e5c342a |
| fmdeps/BRiCk/ | main | b79c734 |
| fmdeps/auto/ | main | ffda14f |
| fmdeps/auto-docs/ | main | 9f57097 |
| bluerock/NOVA/ | skylabs-proof | 996d600 |
| bluerock/bhv/ | skylabs-main | 8d08b1c |
| fmdeps/brick-libcpp/ | main | dc9818e |
| fmdeps/ci/ | main | 7712f8c |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | 262fb04 |
| fmdeps/fm-tools/ | main | 430933c |
| psi/protos/ | main | 8fe3e7c |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 62ed81e |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 7d620c1 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.00% | 122903.6 | 122903.6 | +0.0 | total |
| +0.00% | 22632.5 | 22632.5 | +0.0 | ├ translation units |
| +0.00% | 100271.1 | 100271.1 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| +0.00% | 122903.6 | 122903.6 | +0.0 | total |
| +0.00% | 22632.5 | 22632.5 | +0.0 | ├ translation units |
| +0.00% | 100271.1 | 100271.1 | +0.0 | └ proofs and tests |
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | e5c342a |
| fmdeps/BRiCk/ | main | b79c734 |
| fmdeps/auto/ | main | ffda14f |
| fmdeps/auto-docs/ | main | 9f57097 |
| bluerock/NOVA/ | skylabs-proof | 996d600 |
| bluerock/bhv/ | skylabs-main | 8d08b1c |
| fmdeps/brick-libcpp/ | main | dc9818e |
| fmdeps/ci/ | main | 7712f8c |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | 262fb04 |
| fmdeps/fm-tools/ | main | 430933c |
| psi/protos/ | main | 8fe3e7c |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 62ed81e |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 7d620c1 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122903.5 | 122903.5 | -0.0 | total |
| -0.00% | 22632.4 | 22632.4 | -0.0 | ├ translation units |
| +0.00% | 100271.1 | 100271.1 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122903.5 | 122903.5 | -0.0 | total |
| -0.00% | 22632.4 | 22632.4 | -0.0 | ├ translation units |
| +0.00% | 100271.1 | 100271.1 | +0.0 | └ proofs and tests |
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | e5c342a |
| fmdeps/BRiCk/ | main | b79c734 |
| fmdeps/auto/ | main | ffda14f |
| fmdeps/auto-docs/ | main | 9f57097 |
| bluerock/NOVA/ | skylabs-proof | 996d600 |
| bluerock/bhv/ | skylabs-main | 8d08b1c |
| fmdeps/brick-libcpp/ | main | dc9818e |
| fmdeps/ci/ | main | 7712f8c |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | 262fb04 |
| fmdeps/fm-tools/ | main | 430933c |
| psi/protos/ | main | 8fe3e7c |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 62ed81e |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 7d620c1 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122903.6 | 122903.6 | -0.0 | total |
| -0.00% | 22632.5 | 22632.5 | -0.0 | ├ translation units |
| +0.00% | 100271.1 | 100271.1 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122903.6 | 122903.6 | -0.0 | total |
| -0.00% | 22632.5 | 22632.5 | -0.0 | ├ translation units |
| +0.00% | 100271.1 | 100271.1 | +0.0 | └ proofs and tests |
Contributor
gmalecha-at-skylabs
left a comment
gmalecha-at-skylabs
left a comment
There was a problem hiding this comment.
My main concern right now is that this might be breaking the wire-protocol that we are talking between the client and the server. If so, then we need to do a release afterwards and that warrants more testing. If we can restrict these changes to only affect the logging infrastructure, then we would de-risk this.
While being explicit is a bit verbose, I'm actually thinking that maybe we should go and define very explicit protocol classes so that we can actually rigorously define all of the data types that are used and get all of these statically checked.
Contributor
rlepigre-skylabs-ai
left a comment
rlepigre-skylabs-ai
left a comment
There was a problem hiding this comment.
Everything outside of deserialize.py looks good to me. I have not looked at that last file very much since there are open thread already.
| result: T_resp | ||
|
|
||
|
|
||
| # Note: explicitly /not/ final because clients may want derived exception types |
Contributor
There was a problem hiding this comment.
Not sure this comment is useful honestly.
Suggested change
| # Note: explicitly /not/ final because clients may want derived exception types |
CI summary (Details)Active Repos
|
| Repo | Job Branch | Job Commit |
|---|---|---|
| ./ | main | e5c342a |
| fmdeps/BRiCk/ | main | b79c734 |
| fmdeps/auto/ | main | 61983bb |
| fmdeps/auto-docs/ | main | 9f57097 |
| bluerock/NOVA/ | skylabs-proof | 996d600 |
| bluerock/bhv/ | skylabs-main | 8d08b1c |
| fmdeps/brick-libcpp/ | main | dc9818e |
| fmdeps/ci/ | main | 4f94f40 |
| vendored/elpi/ | skylabs-master | aa4475f |
| fmdeps/fm-ci/ | main | 262fb04 |
| fmdeps/fm-tools/ | main | 430933c |
| psi/protos/ | main | 8fe3e7c |
| psi/ide/ | main | 6b596cf |
| psi/data/ | main | 62ed81e |
| vendored/rocq/ | skylabs-master | 2ede3c9 |
| vendored/rocq-elpi/ | skylabs-master | 103a742 |
| vendored/rocq-equations/ | skylabs-main | a8c4832 |
| vendored/rocq-ext-lib/ | skylabs-master | 94a6630 |
| vendored/rocq-iris/ | skylabs-master | 3ad4ddd |
| vendored/rocq-lsp/ | skylabs-main | a8b7272 |
| vendored/rocq-stdlib/ | skylabs-master | bc07423 |
| vendored/rocq-stdpp/ | skylabs-master | e01d802 |
| fmdeps/skylabs-fm/ | main | 7d620c1 |
| vendored/vsrocq/ | skylabs-main | 5b4527e |
Performance
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122929.5 | 122929.5 | -0.0 | total |
| -0.00% | 22632.7 | 22632.7 | -0.0 | ├ translation units |
| +0.00% | 100296.8 | 100296.8 | +0.0 | └ proofs and tests |
Full Results
| Relative | Master | MR | Change | Filename |
|---|---|---|---|---|
| -0.00% | 122929.5 | 122929.5 | -0.0 | total |
| -0.00% | 22632.7 | 22632.7 | -0.0 | ├ translation units |
| +0.00% | 100296.8 | 100296.8 | +0.0 | └ proofs and tests |
…ydantic BaseModel for Err+Resp
…defaults for microrpc classes
…erialization in microrpc/deserialize.py
…microrpc/deserialize.py#Encoder
…ion tracebacks for logging encoders/decoders
jhaag-skylabs-ai
force-pushed
the
ocaml-jsonrpc-tp/python/use-pydantic
branch
from
736f17d to
34dbfc8
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Note: depends on #282
Preferring pydantic
BaseModels simplifies (de)serialization logic & downstream client code.Closing Conditions
Engineering
BaseModels in APIs:@finalmodel_config:frozen=Trueextra="forbid"BaseModels forErr+Resptypesrocq_doc_manager/cursor/websocket.pyrocq_doc_manager/microrpc/Testing
rocq-remote-agentcorrectly works with the new changesrocq-remote-agentin the released docker image