Experiment: Test https://github.com/rocq-prover/rocq/pull/21208#1
Closed
Janno wants to merge 2 commits into
Closed
Experiment: Test https://github.com/rocq-prover/rocq/pull/21208#1Janno wants to merge 2 commits into
Janno wants to merge 2 commits into
Conversation
All users were synchronized, except that the main entry point was forgetting to end the dumping, since it would exit prematurely. Furthermore, we clean up along the way the internal states of the Dumpglob module. I am not sure this code was really designed this way, it looks like its dire state is the result of organic modification, but this resulted in very dubious bits of code.
Due to the way Ltac runtime is implemented, if a constant is evaluated during a tactic call, it will generate a glob output. In particular, if it is evaluated several times, the glob file will contain the same line repeated again and again, leading to potentially huge glob files. For all consumers, this repetition is useless because they will just overwrite the same data again and again. Said otherwise, clients are idempotent w.r.t. repeated declarations. We leverage this property by simply caching whether a specific reference has already been registered in the glob file and ignoring it otherwise.
Author
|
Very slight slowdown but apparently no significant change in artifact sizes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes / closes #????
make doc_gram_rsts.