printing: add "Printing Fully Qualified" flag for global objects#10
Closed
aa755 wants to merge 1 commit into
Closed
printing: add "Printing Fully Qualified" flag for global objects#10aa755 wants to merge 1 commit into
aa755 wants to merge 1 commit into
Conversation
Introduce the "Printing Fully Qualified" flag to print global objects using fully qualified names. The flag is implemented in printer.ml and affects the core NAMETAB_gen.shortest_qualid_gen function so that all nametabs (XRefs, Modules, ModTypes, Univs, etc.) respect the flag consistently. Add ~force_short:bool parameter (default false) to all shortest_qualid functions. When true, always returns the shortest qualid regardless of the flag. Internal callers that need short names for name-avoidance (termops, namegen, glob_ops, abbreviation, primNotations, extraction) pass ~force_short:true. This provides a simple way to disambiguate same-named constants across modules when using `Search`, `Print Assumptions`, etc. (rocq-prover#21443, fixes rocq-prover#11852) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: JasonGross <396076+JasonGross@users.noreply.github.com> Co-authored-by: Gaëtan Gilbert <gaetan.gilbert@skyskimmer.net> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-picked an upstream PR (NOT MY WORK). there was a merge conflict which codex fixed.