Test Rocq PR #21405#4
Closed
Janno wants to merge 2 commits into
Closed
Conversation
We simply treat them as global levels, by clearly separating the compilation of code that is supposed to quantify over levels from the one that merely passes them around. (cherry picked from commit fe06b97)
This is safer and will make it possible to simplify the code that pushes bound levels and sorts in the environment. We also share more hashconsing for polymorphic entries this way. This also probably fixes a bug with the relevance computation for definitions. The environment passed to the function was the one with the concrete levels, but the term argument was expected to live in the abstracted context. (cherry picked from commit 4bd12be)
|
Performance summary for https://github.com/SkyLabsAI/ci/actions/runs/20029439233/attempts/1
Full Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.