Load layers from image repository#133
Draft
alukach wants to merge 1 commit into
Draft
Conversation
🍹
|
🍹
|
alukach
changed the title
alukach
changed the title
Collaborator
|
Agreed... I don't think this is quite ready to merge into main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I'm changing
Within this PR, we make use of the
cache_fromdirective to load built image layers from GCR. This is described further within this blog post: https://www.pulumi.com/blog/build-images-50x-faster-docker-v4/Impact
I'm not totally certain how much impact this makes. It avoids building by fetching already-built layers, however that fetch operation does take time. I do believe there are some gains from this (largely from avoiding the
pip installoperations from within the container which don't seem to make use of any sort of cache), but probably not the 50x gains described in the aforementioned blog post.Before & After
Before
Total time of build & upload of docker:index:Image cerulean-cloud-images-test-cr-orchestrator-image:
0:03:22After
Total time of build & upload of docker:index:Image cerulean-cloud-images-test-cr-orchestrator-image:
0:04:01Note
So this change may have actually added time to the build process. I'm unsure if it should be retained or not.
I think a more impactful solution could be to retain the Pip cache used within the Docker image between builds. This would probably look like loading the cache in Github Actions, mounting to the docker image before building, and then saving back to Github Actions afterwards.