Recognize intentionally inactive sync homes#371
Merged
Conversation
Deploying wireup-landing with
|
| Latest commit: |
a7d2f02
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3e13d95b.wireup-landing.pages.dev |
| Branch Preview URL: | https://fix-doctor-inactive-sync.wireup-landing.pages.dev |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
ChangesLifecycle-aware sync freshness
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns wire doctor sync freshness with the bounded supervisor lifecycle. An initialized home with no cwd binding, no live lease, and no queued events now reports that its worker is intentionally retired when the supervisor is healthy. Explicitly live homes and queued work retain existing stale-sync warnings/failures.\n\nVerification:\n- TDD RED/GREEN inactive lifecycle verdict\n- 28 doctor unit tests\n- cargo fmt and clippy -D warnings\n- live candidate doctor classified the retired home correctly\n- test-env/run.sh: 659 library tests and 11/11 integration scripts\n- GitNexus detect_changes: LOW, zero affected flows
Summary by CodeRabbit