Skip to content

Recognize intentionally inactive sync homes#371

Merged
laulpogan merged 2 commits into
mainfrom
fix/doctor-inactive-sync
Jul 18, 2026
Merged

Recognize intentionally inactive sync homes#371
laulpogan merged 2 commits into
mainfrom
fix/doctor-inactive-sync

Conversation

@laulpogan

@laulpogan laulpogan commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Aligns wire doctor sync freshness with the bounded supervisor lifecycle. An initialized home with no cwd binding, no live lease, and no queued events now reports that its worker is intentionally retired when the supervisor is healthy. Explicitly live homes and queued work retain existing stale-sync warnings/failures.\n\nVerification:\n- TDD RED/GREEN inactive lifecycle verdict\n- 28 doctor unit tests\n- cargo fmt and clippy -D warnings\n- live candidate doctor classified the retired home correctly\n- test-env/run.sh: 659 library tests and 11/11 integration scripts\n- GitNexus detect_changes: LOW, zero affected flows

Summary by CodeRabbit

  • Bug Fixes
    • Improved sync freshness diagnostics for intentionally inactive or retired identities.
    • Prevented misleading warnings or failures when no work is queued and the identity is not expected to run.
    • Preserved existing diagnostics for identities with queued work or active runtime status.
    • Added coverage confirming inactive identities are correctly reported as passing.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wireup-landing with  Cloudflare Pages  Cloudflare Pages

Latest commit: a7d2f02
Status: ✅  Deploy successful!
Preview URL: https://3e13d95b.wireup-landing.pages.dev
Branch Preview URL: https://fix-doctor-inactive-sync.wireup-landing.pages.dev

View logs

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c66d6e67-5879-4584-84f1-135829aa1bd1

📥 Commits

Reviewing files that changed from the base of the PR and between b6a6d49 and a7d2f02.

📒 Files selected for processing (2)
  • SESSION_LOG_2026_07_18.md
  • src/cli/status.rs

📝 Walkthrough

Walkthrough

wire doctor now evaluates sync freshness against supervisor topology and session lifecycle state, passing inactive identities with no queued events. A unit test validates the policy, and the session log records deployment verification and final gate results.

Changes

Lifecycle-aware sync freshness

Layer / File(s) Summary
Inactive worker expectation and freshness verdicts
src/cli/status.rs, SESSION_LOG_2026_07_18.md
Lifecycle-aware helpers and supervisor topology determine whether a worker is expected; inactive identities without queued events receive PASS, with the behavior covered by a unit test and deployment results recorded in the session log.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • SlanchaAI/wire#370: Introduced supervisor-derived runtime topology used by this sync freshness lifecycle logic.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: recognizing intentionally inactive sync homes in doctor freshness checks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/doctor-inactive-sync

Comment @coderabbitai help to get the list of available commands.

@laulpogan
laulpogan merged commit 7f2301b into main Jul 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant