Skip to content

Add feature: Delete field values #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Christian-Toney merged 1 commit into from
Feb 25, 2026
Merged

Add feature: Delete field values #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 31 additions & 31 deletions src/routes/field-values/{field_value_id}/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,37 +67,37 @@ async fn handle_get_field_value_request(

}

// /// DELETE /field-values/{field_value_id}
// ///
// /// Deletes an app by its ID.
// #[axum::debug_handler]
// async fn handle_delete_app_request(
// Path(field_value_id): Path<String>,
// State(state): State<AppState>,
// Extension(http_transaction): Extension<Arc<HTTPTransaction>>,
// Extension(authenticated_user): Extension<Option<Arc<User>>>,
// Extension(authenticated_app): Extension<Option<Arc<App>>>,
// Extension(authenticated_app_authorization): Extension<Option<Arc<AppAuthorization>>>
// ) -> Result<StatusCode, HTTPError> {

// let field_value_id = get_uuid_from_string(&field_value_id, "app", &http_transaction, &state.database_pool).await?;
// let response = delete_resource(
// State(state),
// Extension(http_transaction),
// Extension(authenticated_user),
// Extension(authenticated_app),
// Extension(authenticated_app_authorization),
// Some(&AccessPolicyResourceType::App),
// &field_value_id,
// "apps.delete",
// "app",
// &ActionLogEntryTargetResourceType::App,
// |field_value_id, database_pool| Box::new(App::get_by_id(field_value_id, database_pool))
// ).await;

// return response;
/// DELETE /field-values/{field_value_id}
///
/// Deletes a field value by its ID.
#[axum::debug_handler]
async fn handle_delete_field_value_request(
Path(field_value_id): Path<String>,
State(state): State<AppState>,
Extension(http_transaction): Extension<Arc<HTTPTransaction>>,
Extension(authenticated_user): Extension<Option<Arc<User>>>,
Extension(authenticated_app): Extension<Option<Arc<App>>>,
Extension(authenticated_app_authorization): Extension<Option<Arc<AppAuthorization>>>
) -> Result<StatusCode, HTTPError> {

// }
let field_value_id = get_uuid_from_string(&field_value_id, "field value", &http_transaction, &state.database_pool).await?;
let response = delete_resource(
State(state),
Extension(http_transaction),
Extension(authenticated_user),
Extension(authenticated_app),
Extension(authenticated_app_authorization),
Some(&AccessPolicyResourceType::FieldValue),
&field_value_id,
"fieldValues.delete",
"field value",
&ActionLogEntryTargetResourceType::FieldValue,
|field_value_id, database_pool| Box::new(FieldValue::get_by_id(field_value_id, database_pool))
).await;

return response;

}

// /// PATCH /field-values/{field_value_id}
// ///
Expand Down Expand Up @@ -185,7 +185,7 @@ pub fn get_router(state: AppState) -> Router<AppState> {

let router = Router::<AppState>::new()
.route("/field-values/{field_value_id}", axum::routing::get(handle_get_field_value_request))
// .route("/field-values/{field_value_id}", axum::routing::delete(handle_delete_app_request))
.route("/field-values/{field_value_id}", axum::routing::delete(handle_delete_field_value_request))
// .route("/field-values/{field_value_id}", axum::routing::patch(handle_patch_app_request))
.layer(axum::middleware::from_fn_with_state(state.clone(), authentication_middleware::authenticate_user))
.layer(axum::middleware::from_fn_with_state(state.clone(), authentication_middleware::authenticate_app))
Expand Down
Loading