fix(editor-web): resolve API crashes and strict typescript compilation errors#4
Merged
Merged
Conversation
The project save handler (and all other project API handlers) called projectsDir() as a function, but no such function existed. Only studioSettings.projectsDir (a string) was defined. This caused a TypeError caught by the bare catch block, surfaced as the generic 'Failed to save project' error. Also improves the catch block to log and return the actual error message instead of swallowing it.
…aps in vite config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes multiple editor web app regressions that broke both the build step and the node server export APIs. Specifically:
path.resolvecrash forprojectsDir()introduced in a previous draft PR when project fallback defaults were missing.aafBridgeJobs,edlJobs, etc.) insidevite.config.tsfixingtscresolution failures.vite.config.tsby resolvingprobeFcpxmlMetadatacorrectly and casting keepRanges into expected timeline format objects viatoTimelineKeepRanges.TranscribeStateLikeandExportStateLiketo conform with React job polling constraints.@types/node,@types/react,@types/react-dom, and standardizesvite-env.d.tsto finally drop the compilation error count from ~1700 to 0.Fixes #1