Skip to content

Dev dash#185

Open
mihalikv wants to merge 7 commits into
mainfrom
dev_dash
Open

Dev dash#185
mihalikv wants to merge 7 commits into
mainfrom
dev_dash

Conversation

@mihalikv

Copy link
Copy Markdown
Contributor

No description provided.

…t functionality

Introduced grouped AJAX calls for dashboard widgets, enabling parent widgets to refresh data for multiple subwidgets in a single request. Added `SBAdminDashboardHtmlWidget` and `SBAdminDashboardGroupWidget` for managing grouped widgets efficiently. Updated related tests, templates, and documentation.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 781afe7c50

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/django_smartbase_admin/engine/dashboard.py
Comment on lines +16 to +17
const form = document.getElementById(this.formId)
const entries = form ? new FormData(form).entries() : new FormData()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include grouped child filter values in refreshes

When a grouped child chart has its own filters/settings (for example SBAdminDashboardChartWidgetByDate renders date/resolution controls), those inputs are initialized with the child widget's form id, but the group refresh serializes only this.formId for the parent group. Because grouped charts no longer issue their own AJAX request, changes to the child controls are never sent to get_data, so the chart keeps using the old/default data; either collect the child form values here or avoid rendering child filters in grouped mode.

Useful? React with 👍 / 👎.

mihalikv added 3 commits June 19, 2026 11:59
Improved documentation for dashboard widgets, detailing simple, lightweight subwidgets, real subwidgets with separate AJAX, and grouped AJAX options. Updated examples and descriptions to align with recent dashboard changes and improved organization for clarity.
mihalikv added 2 commits June 19, 2026 17:44
Integrated `DashboardParentFilterModule` for hierarchical filtering in widgets, supporting parent-child data relationships. Updated templates, JavaScript, and admin logic to enable dynamic subwidget filtering and improved widget registration. Extended tests and constants for additional functionality.
…oup`

Enhanced `SBAdminDashboardGroup` to handle multiple filter forms. Added `filterFormIds` method, updated `formValues` logic, and refined filter input event listeners to support dynamic multi-form filtering. Updated subwidget registration to include `formId`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant