refactor: simplify tabulator column handling and introduce primary ke…#188
Conversation
…y filter widget - Renamed `get_tabulator_columns_add_id_column_if_missing` to `get_tabulator_columns` for clarity. - Removed the logic for conditionally adding an ID column, now handled by `get_effective_list_display`. - Introduced `PrimaryKeyFilterWidget` to allow filtering by primary key, enhancing the usability of the list view. - Updated tests to ensure proper functionality of the new primary key handling and filtering capabilities.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e075ca698
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex re-review with fixes |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff37499a11
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex re-review fixes |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8cc6bc8b1a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex all good? |
|
To use Codex here, create a Codex account and connect to github. |
2 participants
…y filter widget
get_tabulator_columns_add_id_column_if_missingtoget_tabulator_columnsfor clarity.get_effective_list_display.PrimaryKeyFilterWidgetto allow filtering by primary key, enhancing the usability of the list view.