Use shaded cassandra jar to avoid netty conflicts with ratpack. #16
Open
jterhune wants to merge 1 commit intoSmartThingsOSS:masterfrom
Open
Use shaded cassandra jar to avoid netty conflicts with ratpack. #16jterhune wants to merge 1 commit intoSmartThingsOSS:masterfrom
jterhune wants to merge 1 commit intoSmartThingsOSS:masterfrom
Conversation
…required removal of the shareEventLoopGroup option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into netty version problems when trying to get cassandra unit working in a project. Unfortunately, switching to the shaded jar required removal of the shareEventLoopGroup option. Per the documentation the netty layer is no longer configurable: https://docs.datastax.com/en/developer/java-driver/3.1/manual/shaded_jar/#limitations
Given the breaking change, I'm not sure this is worth merging, but I figured I'd create the PR for reference.