Return 'destination' only TDS Reports#1
Open
paulespinosa wants to merge 1 commit into
Open
Conversation
IRP uses TIS to analyze test scores. This change will cause TIS to return the File ID of the file it is submitting to be scored and return only a TDS Report if it is marked with the 'destination' location in the XMLRepository table.
Contributor
|
Thanks Paul. We will review and let you know if we have any questions. |
jtreuting
reviewed
Feb 7, 2017
| using (HttpClient client = new HttpClient()) | ||
| { | ||
| response = client.GetAsync(String.Format("{0}?access_token={1}", OpenAMUrl, authKey)).Result; | ||
| response = client.GetAsync(String.Format("{0}?access_token={1}&realm=/sbac", OpenAMUrl, authKey)).Result; |
Contributor
There was a problem hiding this comment.
Was it not working for you without the realm? I'm asking because we have stood TIS up and used it and we did not need to change this.
Author
There was a problem hiding this comment.
Correct, it didn't work without the realm. Should I take it out of this pull request?
Contributor
There was a problem hiding this comment.
Not yet. I'm going to double check before and after for that since it does seem like it should be there. I'm just surprised that we didn't see an issue with it before. So I'm confused :) . But leave at this point. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IRP uses TIS to analyze test scores. This change will cause TIS to
return the File ID of the file it is submitting to be scored and return
only a TDS Report if it is marked with the 'destination' location in the
XMLRepository table.